This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, Fortran, F03] PR 40870: include formal args in backend_decl of PPCs
On Tuesday 04 August 2009 11:28:57 Paul Richard Thomas wrote:
> This does not look right to me because you are shorting out
> (gfc_get_derived_type):
>
> /* derived->backend_decl != 0 means we saw it before, but its
> components' backend_decl may have not been built. */
> if (derived->backend_decl)
> {
> /* Its components' backend_decl have been built. */
> if (TYPE_FIELDS (derived->backend_decl))
> return derived->backend_decl;
> else
> typenode = derived->backend_decl;
> }
>
> Has this test become unnecessary for some reason or had you better
> test for the TYPE_FIELDS in the bit that you introduced above?
> Anyway, try the attached for size - it bootstraps and regtests on
> x86_64/FC9.
No idea if it's related, but I've seen this piece before.
It was (re-)introduced to fix PR40594.
Cheers
Daniel