This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Dwarf2 "main" pointer die for VMS
- From: Jim Wilson <wilson at codesourcery dot com>
- To: Douglas B Rupp <rupp at gnat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sun, 02 Aug 2009 18:46:04 -0700
- Subject: Re: [PATCH] Dwarf2 "main" pointer die for VMS
- References: <4A68C654.5080205@gnat.com>
On 07/23/2009 01:21 PM, Douglas B Rupp wrote:
The VMS debugger needs this.
You are adding a variable and function prototype in a section of code
for debug hooks, and these aren't debug hooks. It seems more
appropriate to put them about 400 lines later where the bulk of the
dwarf2 function prototypes are.
A blank line between the variable definition and the function prototype
would be good, and a comment for the variable would be nice.
I see that you are setting the variable, but you are never clearing it
or freeing the string anywhere. I think the variable should be
initialized to zero in dwarf2out_init just to be safe. Most everything
else in the file is initialized here.
Otherwise this looks OK to me.
If you already have other VMS_DEBUGGING_INFO stuff approved, then it
would be nice if the VMS stuff can be grouped together to reduce the
number of ifdefs.
Jim