This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Handle VMS common object attribute on IA64
- From: Jim Wilson <wilson at codesourcery dot com>
- To: Douglas B Rupp <rupp at gnat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, sje at cup dot hp dot com
- Date: Sun, 02 Aug 2009 12:20:21 -0700
- Subject: Re: [PATCH] Handle VMS common object attribute on IA64
- References: <4A71231E.9030007@gnat.com>
On Wed, 2009-07-29 at 21:35 -0700, Douglas B Rupp wrote:
> This is VMS specific feature used in GNAT
> OK to commit?
The patch adds 3 functions, none of which have explanatory comments
before them.
The warning call uses explicit quote/backquote characters when it should
be using %q to get character set appropriate quotes.
The patch includes a ia64_vms_elf_asm_named_section function that
logically isn't part of the common object attribute support, but that is
OK. I see that it is used by code in the new vms.h file in a different
patch.
Otherwise this looks OK to me. Steve Ellcey may have other comments.
Long term maybe we should add a SUBTARGET_ATTIBUTE_TABLE macro that some
other ports already use? This avoids the need for an ifdef here. If
you don't want some of the linux specific attributes defined, we could
move them into a linux SUBTARGET_ATTRIBUTE_TABLE macro definition.
Jim