This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] VMS ABI stuff for IA64
- From: Jim Wilson <wilson at codesourcery dot com>
- To: Douglas B Rupp <rupp at gnat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, sje at cup dot hp dot com
- Date: Sun, 02 Aug 2009 10:01:10 -0700
- Subject: Re: [PATCH] VMS ABI stuff for IA64
- References: <4A7109DB.7030909@gnat.com>
On Wed, 2009-07-29 at 19:47 -0700, Douglas B Rupp wrote:
> +static enum ivms_arg_type
> +ia64_arg_type (enum machine_mode mode)
> +{
> + switch (mode)
> + {
> + case SFmode:
> + return FS;
> + case DFmode:
> + return FT;
> + default:
> + return I64;
> + }
> +}
There is no explanatory comment before this function.
> +enum ivms_arg_type {I64, FF, FD, FG, FS, FT};
These enum values look cryptic. Maybe they have something to do with FP
formats? Vax had a G float format in addition to the standard F and D
float format types. A comment would be nice.
> +
> typedef struct ia64_args
> {
> int words; /* # words of arguments so far */
> int int_regs; /* # GR registers used so far */
> int fp_regs; /* # FR registers used so far */
> int prototype; /* whether function prototyped */
> + enum ivms_arg_type atypes[8];
> } CUMULATIVE_ARGS;
All structure fields are commented, except the one you just added.
Otherwise the rest of the patch looked fine to me.
Jim