This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PING] Enable pragma redefine_extname on all targets
On Fri, 31 Jul 2009, Olatunji Ruwase wrote:
> >
> > The patch appears to add a bogus blank line at the start of two C front
> > end files and to fail to adjust the indentation of the body of an if when
> > removing the "if" line.
> >
>
> All issues fixed.
Now you're changing two lines in c-cppbuiltin.c from empty (correct) to
containing just two spaces (incorrect, we avoid trailing whitespace
whenever possible). Please read your patches carefully to make sure they
do not include any accidental side-effects of the editing process such as
these, just the changes you intended to include. The C front end changes
are OK with this fixed.
--
Joseph S. Myers
joseph@codesourcery.com