This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFA: Define MULTILIB_ABI_DEFAULT for mips64vr*-*-elf* targets
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: Nick Clifton <nickc at redhat dot com>
- Cc: echristo at apple dot com, gcc-patches at gcc dot gnu dot org
- Date: Fri, 17 Jul 2009 18:15:32 +0100
- Subject: Re: RFA: Define MULTILIB_ABI_DEFAULT for mips64vr*-*-elf* targets
- References: <m3ocrjpvbn.fsf@redhat.com>
Hi Nick,
Nick Clifton <nickc@redhat.com> writes:
> This probably counts as an obvious patch, but I thought that I would
> check with you first:
>
> The mips64vr-*-elf* and mips64vrel-*-elf* targets make use of the
> mips/vr.h header file. This redefines MIPS_ABI_DEFAULT to be
> ABI_EABI. Unfortunately it does not, currently, redefine
> MULTILIB_ABI_DEFAULT as well. This means that in the definition of
> MULTILIB_DEFAULTS that follows the default abi is still set to
> mips32 which means that the wrong set of multilibs are built.
>
> Fixed by applying the patch below and tested by building a
> mips64vrel-elf toolchain and running the gcc testsuite with a
> -mabi=32 selector.
Hmm. I think it'd be better to move the MIPS_ABI_DEFAULT definition
from mips/vr.h to config.gcc, which is how we handle this for other
configurations. Then the mips.h logic will DTRT.
A patch to do that is preapproved.
Richard