This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch][plugin] Export constant pool


2009/7/15 Olatunji Ruwase <tjruwase@google.com>:
> Hi,
> ÂThis patch makes the constant pool (const_desc_htab) global. Plugins
> such as mudflap that need to
> Âprocess(instrument) constants will benefit from this.
>
> ÂBootstrap and tested on x86_64-unknown-linux-gnu.

Could you please add a comment saying why it is not static?

I think the patch is correct, but I cannot approve it.


> Thanks,
>
> tunji
>

Cheers,
-- 
Rafael Avila de Espindola

Google | Gordon House | Barrow Street | Dublin 4 | Ireland
Registered in Dublin, Ireland | Registration Number: 368047


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]