This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch committed: Make exact_log2 and floor_log2 static inline
- From: Andrew Pinski <pinskia at gmail dot com>
- To: Ian Lance Taylor <iant at google dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 16 Jun 2009 10:05:17 -0700
- Subject: Re: Patch committed: Make exact_log2 and floor_log2 static inline
- References: <20090616165802.4350.qmail@pepe.airs.com>
On Tue, Jun 16, 2009 at 9:58 AM, Ian Lance Taylor<iant@google.com> wrote:
> The functions exact_log2 and floor_log2 are defined in toplev.h and
> toplev.c as GNU89 extern inline functions. ÂThis does not work right
> with C++ or with C99. ÂFor C99 we could use the gnu_inline attribute,
> but there is really no advantage to doing so.
GNU C++ also has the gnu_inline attribute. Have you benchmarked the
compiler after this change? What about size difference in the
produced cc1/cc1plus (this is the advantage for doing it this way
really)? Does it change a lot?
Thanks,
Andrew Pinski