This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Add and use new RTL predicates for i386 target


Shujing Zhao wrote:
Thanks. Remove the extra parentheses.
On 06/12/2009 04:22 PM, Paolo Bonzini wrote:
I must say I don't see the point of extra RTL predicates, but I'll let others judge. MEM and REG should be everything that's needed IMHO.

I found the point from "Simple GCC Projects":

Yes, that's what I disagree with. :-)


Actually to be a bit less pedantic, I'd say I agree with predicates for every RTL expression in class RTX_OBJECT (REG, MEM, SUBREG, SYMBOL_REF and a few others). I would even love to have SUBREG_REG_P for

GET_CODE (X) == SUBREG && GET_CODE (SUBREG_REG (X)) == REG

In the end it was SET_P and PLUS_P that I didn't like (though I know they're quite frequent), and PARALLEL_P that I didn't feel the need for.

Paolo


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]