This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix trunk profiledbootstrap in fortran FE

From: Jakub Jelinek <jakub at redhat dot com>
To: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
Cc: gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org
Date: Wed, 10 Jun 2009 17:50:19 +0200
Subject: Re: [PATCH] Fix trunk profiledbootstrap in fortran FE
References: <20090610152606.GX4822@tyan-ft48-01.lab.bos.redhat.com> <20090610154524.GA71850@troutmask.apl.washington.edu>
Reply-to: Jakub Jelinek <jakub at redhat dot com>

On Wed, Jun 10, 2009 at 08:45:24AM -0700, Steve Kargl wrote:
> > 	* interface.c (fold_unary): Rename to...
> > 	(gfc_fold_unary): ... this.
> > 	(gfc_extend_expr): Adjust caller.
> 
> By convention the Fortran FE normally uses the gfc_ prefix
> on non-static functions.  If the function is static, the 
> gfc_ is omitted.  I don't recall the origins of this convention.
> Can you add a small comment above gfc_fold_unary?  Something
> like
> 
> /* gfc_ prefix used to avoid possible conflicts with middle-end
>    fold_unary() function.  */

In that case, wouldn't it be better renamed to e.g.
fold_unary_intrinsic instead (and no extra comment)?

	Jakub

Follow-Ups:
- Re: [PATCH] Fix trunk profiledbootstrap in fortran FE
  - From: Steve Kargl

References:
- [PATCH] Fix trunk profiledbootstrap in fortran FE
  - From: Jakub Jelinek
- Re: [PATCH] Fix trunk profiledbootstrap in fortran FE
  - From: Steve Kargl

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]