This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [LTO] fix ipa-cp
- From: Diego Novillo <dnovillo at google dot com>
- To: Jan Hubicka <hubicka at ucw dot cz>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 9 Jun 2009 14:25:08 -0400
- Subject: Re: [LTO] fix ipa-cp
- References: <20090609170606.GA6757@kam.mff.cuni.cz>
2009/6/9 Jan Hubicka <hubicka@ucw.cz>:
> I get following failures, but I think they are not related to the
> change.
Yes. These are all existing libstdc++ failures.
> Â Â Â Â* ipa-reference.c (add_new_function, remove_node_data,
> Â Â Â Âduplicate_node_data): Declare.
> Â Â Â Â(ipa_init): Initialize hooks here.
> Â Â Â Â(generate_summary): Do not initialize them here.
> Â Â Â Â* ipa-pure-const.c (get_function_state): Revert earlier Raphael's change.
Better describe what you reverted. Either point to the reverted patch
or just describe what changed.
> + static void add_new_function (struct cgraph_node *node,
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â void *data ATTRIBUTE_UNUSED);
> + static void remove_node_data (struct cgraph_node *node,
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â void *data ATTRIBUTE_UNUSED);
> + static void duplicate_node_data (struct cgraph_node *src,
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âstruct cgraph_node *dst,
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âvoid *data ATTRIBUTE_UNUSED);
No need to use arg names and ATTRIBUTE_UNUSED in forward declarations.
Are these really needed to be forward declared?
Patch looks OK otherwise.
Thanks for the fix!
Diego.