This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Whitespace fixes

From: Gerald Pfeifer <gerald at pfeifer dot com>
To: Bernhard Reutner-Fischer <rep dot dot dot nop at gmail dot com>
Cc: Richard Guenther <richard dot guenther at gmail dot com>, gcc-patches at gcc dot gnu dot org
Date: Sat, 6 Jun 2009 22:29:16 +0200 (CEST)
Subject: Re: [PATCH] Whitespace fixes
References: <63213a79c5a038d6b53d8ab38d547b269955252f.1244122541.git.rep.dot.nop@gmail.com> <20090605192628.GA24527@mx.loc> <84fc9c000906051241g2c266a94r2e495451cbad7ca4@mail.gmail.com> <20090606125935.GE28853@mx.loc>

On Sat, 6 Jun 2009, Bernhard Reutner-Fischer wrote:
> 2) Can we have a pre-commit hook that rejects any patch that
>    a) leaves whitespace-damage in a file that was touched, forcing
>       people to fixup complete files they touch.

I don't think this is a good idea at all.  "Real" changes and whitespace 
fixes in other parts of the code should not be mixed, let alone forced
to be done together.

Gerald

References:
- [PATCH] Whitespace fixes
  - From: Bernhard Reutner-Fischer
- Re: [PATCH] Whitespace fixes
  - From: Richard Guenther
- Re: [PATCH] Whitespace fixes
  - From: Bernhard Reutner-Fischer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]