This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Allow reporting statistics when current_pass->id is -1

From: Andrey Belevantsev <abel at ispras dot ru>
To: Paolo Bonzini <paolo dot bonzini at gmail dot com>
Cc: Richard Guenther <richard dot guenther at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Wed, 03 Jun 2009 19:20:15 +0400
Subject: Re: [PATCH] Allow reporting statistics when current_pass->id is -1
References: <4A2683EC.90006@ispras.ru> <84fc9c000906030724x225394c4tf9be135f5d5e257@mail.gmail.com> <4A269439.4030706@gmail.com>

Paolo Bonzini wrote:

Richard Guenther wrote:
2009/6/3 Andrey Belevantsev <abel@ispras.ru>:
Hello,

The statistics.c code crashes when trying to record an event during the pass which number is -1. This doesn't allow reporting statistics for alias export when the event gets added rom pass_clean_state. Fixed as follows (with assert that this would not happen again), bootstrapped and tested on x86-64, and it also works with alias export. Ok for trunk?
No, rather the patch at http://gcc.gnu.org/ml/gcc-patches/2009-06/msg00113.html should be committed that removes the case of pass number == -1.

Too late :) But I can revert my patch when this one will be in.

Andrey

References:
- [PATCH] Allow reporting statistics when current_pass->id is -1
  - From: Andrey Belevantsev
- Re: [PATCH] Allow reporting statistics when current_pass->id is -1
  - From: Richard Guenther
- Re: [PATCH] Allow reporting statistics when current_pass->id is -1
  - From: Paolo Bonzini

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]