This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [vta, trunk?] oops, one more: don't crash on ppc64's expr_lists in parallels
- From: Alexandre Oliva <aoliva at redhat dot com>
- To: Ian Lance Taylor <iant at google dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 02 Jun 2009 04:58:55 -0300
- Subject: Re: [vta, trunk?] oops, one more: don't crash on ppc64's expr_lists in parallels
- References: <orskr89297.fsf@oliva.athome.lsd.ic.unicamp.br> <orzlcswex6.fsf@free.oliva.athome.lsd.ic.unicamp.br> <m3y6sb7vi0.fsf@google.com>
On Jun 1, 2009, Ian Lance Taylor <iant@google.com> wrote:
> Alexandre Oliva <aoliva@redhat.com> writes:
>> if (GET_CODE (in_rtx) == EXPR_LIST
>> || GET_CODE (in_rtx) == INSN_LIST)
>> fprintf (outfile, ":%s",
>> - GET_REG_NOTE_NAME (GET_MODE (in_rtx)));
>> + (int)GET_MODE (in_rtx) >= REG_NOTE_MAX
>> + ? GET_MODE_NAME (GET_MODE (in_rtx))
>> + : GET_REG_NOTE_NAME (GET_MODE (in_rtx)));
> Write this as
> if ((GET_CODE (in_rtx) == EXPR_LIST
> || GET_CODE (in_rtx) == INSN_LIST)
> && (int) GET_MODE (in_rtx) < (int) REG_NOTE_MAX)
> (rather than duplicating GET_MODE_NAME).
Just to be sure... Are you suggesting we refrain from printing the mode
of an EXPR_LIST and INSN_LIST when the mode is not in the REG_NOTE
range?
--
Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/ FSF Latin America board member
Free Software Evangelist Red Hat Brazil Compiler Engineer