This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch mingw]: Adds for mingw targets the EH thread code to libgcc
- From: Kai Tietz <ktietz70 at googlemail dot com>
- To: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- Cc: Kai Tietz <Kai dot Tietz at onevision dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Danny Smith <dansmister at gmail dot com>
- Date: Sat, 30 May 2009 11:40:41 +0200
- Subject: Re: [patch mingw]: Adds for mingw targets the EH thread code to libgcc
- References: <OF823B6646.7B548649-ONC12575C4.004AFCB5-C12575C4.004BE960@onevision.de> <4A1E9FDA.1090401@gmail.com>
2009/5/28 Dave Korn <dave.korn.cygwin@googlemail.com>:
> Kai Tietz wrote:
>
>> I tested this patch for i686-pc-cygwin and for i686-pc-mingw32 (by
>> mingw.org's runtime).
>
>> Is this patch ok for apply, or are there any further suggestions, or any
>> objectives?
>
> ?No objections. ?I think that:
>
>> ? ? ? ? * gthr-win32.h (MINGW32_SUPPORTS_MT_EH): Define
>> ? ? ? ? it for targets defining _WIN32 but not __CYGWIN__.
>
> ... you don't really need to worry too much about this angle. ?We don't
> support win32 threads on Cygwin, only --enable-threads=posix is important to us.
>
> ? ?cheers,
> ? ? ?DaveK
>
Ok, I applied it. As we have now mthreads support in shared libgcc, we
should deprecate the -mthreads option, or we should change spec files
here and avoid the linking of libmingwthrd.a at all. If we do so, we
need to add the definition of _CRT_MT for static libgcc, too.
Danny, what's your opinion about this?
Cheers,
Kai
--
| (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination