This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: [4.5 Regression] RPR c/40172: evision 147596 breaks bootstrap
2009/5/19 Jakub Jelinek <jakub@redhat.com>:
> On Tue, May 19, 2009 at 10:49:34AM +0200, Manuel López-Ibáñez wrote:
>> Patch. Not bootstrapped or tested yet.
>
> Thanks.
>
>> --- gcc/c-opts.c ? ? ?(revision 147679)
>> +++ gcc/c-opts.c ? ? ?(working copy)
>> @@ -1073,8 +1073,6 @@
>> ? ? ?warn_override_init = extra_warnings;
>> ? ?if (warn_ignored_qualifiers == -1)
>> ? ? ?warn_ignored_qualifiers = extra_warnings;
>> - ?if (warn_logical_op == -1)
>> - ? ?warn_logical_op = extra_warnings;
>>
>> ? ?/* -Wpointer-sign is disabled by default, but it is enabled if any
>> ? ? ? of -Wall or -pedantic are given. ?*/
>
> Shouldn't then:
> Wlogical-op
> C ObjC C++ ObjC++ Var(warn_logical_op) Init(-1) Warning
> Warn when a logical operator is suspiciously always evaluating to true or false
> in c.opt have Init(-1) dropped then, to avoid warn_logical_op being -1?
Good catch! It should be Init(0)
Cheers,
Manuel.