This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix bootstrap when no --with-ppl/--with-cloog [was Re: What precisely is the status of ppl/cloog anyway?]
- From: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- To: Paolo Bonzini <bonzini at gnu dot org>
- Cc: Dave Korn <dave dot korn dot cygwin at googlemail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 06 May 2009 19:14:23 +0100
- Subject: Re: [PATCH] Fix bootstrap when no --with-ppl/--with-cloog [was Re: What precisely is the status of ppl/cloog anyway?]
- References: <4A01ABEF.9060708@gmail.com> <4A01AE78.1040604@gnu.org> <4A01B763.3020001@gmail.com> <4A01C9EB.5020604@gmail.com> <4A01CBD8.4060101@gnu.org>
Paolo Bonzini wrote:
>> * configure.ac ($with_ppl): Default to no if not supplied.
>> ($with_cloog): Likewise.
>>
>> Assuming it passes bootstrap, ok for HEAD?
>
> No, please use the fourth parameter to AC_ARG_WITH (with_ppl=no resp.
> with_cloog=no). No need to bootstrap, just run "sh -n configure" and
admin@ubik /gnu/gcc/obj7ppl2
$ sh -n /gnu/gcc/gcc/configure ; echo $?
0
admin@ubik /gnu/gcc/obj7ppl2
$
I also ran the configure, and then grepped "cloog" in config.log and
config.status; before, I had:
admin@ubik /gnu/gcc/obj7ppl
$ grep cloog config.status config.log
config.status:s,@LIBS@,-L/lib -lcloog -L/lib -lppl_c -lppl -lgmpxx ,;t t
config.status:s,@clooglibs@,-L/lib -lcloog,;t t
config.status:s,@clooginc@,-I/include -DCLOOG_PPL_BACKEND ,;t t
config.log:LIBS='-L/lib -lcloog -L/lib -lppl_c -lppl -lgmpxx '
config.log:clooginc='-I/include -DCLOOG_PPL_BACKEND '
config.log:clooglibs='-L/lib -lcloog'
admin@ubik /gnu/gcc/obj7ppl
... and after, I see:
admin@ubik /gnu/gcc/obj7ppl2
$ grep cloog config.status config.log
config.status:s,@clooglibs@,,;t t
config.status:s,@clooginc@,,;t t
config.log:clooginc=''
config.log:clooglibs=''
admin@ubik /gnu/gcc/obj7ppl2
$
> post for once also the "svn diff configure" so that I can visually
> inspect the changes in generated files.
Attached.
ChangeLog:
* configure.ac ($with_ppl): Default to no if not supplied.
($with_cloog): Likewise.
configure: Regenerate.
Ok?
cheers,
DaveK
Index: configure
===================================================================
--- configure (revision 147098)
+++ configure (working copy)
@@ -4843,6 +4843,8 @@
if test "${with_ppl+set}" = set; then
withval="$with_ppl"
+else
+ with_ppl=no
fi;
# Check whether --with-ppl_include or --without-ppl_include was given.
@@ -4961,6 +4963,8 @@
if test "${with_cloog+set}" = set; then
withval="$with_cloog"
+else
+ with_cloog=no
fi;
# Check whether --with-cloog_include or --without-cloog_include was given.
Index: configure.ac
===================================================================
--- configure.ac (revision 147098)
+++ configure.ac (working copy)
@@ -1339,7 +1339,7 @@
AC_ARG_WITH(ppl, [ --with-ppl=PATH Specify prefix directory for the installed PPL package
Equivalent to --with-ppl-include=PATH/include
- plus --with-ppl-lib=PATH/lib])
+ plus --with-ppl-lib=PATH/lib],, with_ppl=no)
AC_ARG_WITH(ppl_include, [ --with-ppl-include=PATH Specify directory for installed PPL include files])
AC_ARG_WITH(ppl_lib, [ --with-ppl-lib=PATH Specify the directory for the installed PPL library])
@@ -1394,7 +1394,7 @@
AC_ARG_WITH(cloog, [ --with-cloog=PATH Specify prefix directory for the installed CLooG-PPL package
Equivalent to --with-cloog-include=PATH/include
- plus --with-cloog-lib=PATH/lib])
+ plus --with-cloog-lib=PATH/lib],, with_cloog=no)
AC_ARG_WITH(cloog_include, [ --with-cloog-include=PATH Specify directory for installed CLooG include files])
AC_ARG_WITH(cloog_lib, [ --with-cloog-lib=PATH Specify the directory for the installed CLooG library])