This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [C++ PATCH] Fix ICE in tsubst with VLA in template (PR c++/40013)

From: Jason Merrill <jason at redhat dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Mon, 04 May 2009 12:41:32 -0400
Subject: Re: [C++ PATCH] Fix ICE in tsubst with VLA in template (PR c++/40013)
References: <20090504112458.GX5781@tyan-ft48-01.lab.bos.redhat.com>

Jakub Jelinek wrote:

+	/* Fix up type of the magic NOP_EXPR with TREE_SIDE_EFFECTS if
+	   needed.  */
+	if (TREE_CODE (max) == NOP_EXPR
+	    && TREE_SIDE_EFFECTS (max)
+	    && !TREE_TYPE (max))
+	  TREE_TYPE (max) = TREE_TYPE (TREE_OPERAND (max, 0));

This will only work by accident, as we haven't set the magic TREE_SIDE_EFFECTS yet. Might as well move up the code that sets it and set TREE_TYPE too if needed.

Jason

Follow-Ups:
- Re: [C++ PATCH] Fix ICE in tsubst with VLA in template (PR c++/40013)
  - From: Jakub Jelinek

References:
- [C++ PATCH] Fix ICE in tsubst with VLA in template (PR c++/40013)
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]