This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Don't add a new label for implicit default label if case labels cover the whole range (PR middle-end/39666)
On Thu, Apr 30, 2009 at 10:59 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Thu, Apr 30, 2009 at 01:13:22AM +0200, Eric Botcazou wrote:
>> > Maybe Eric can confirm if gigi uses base types for switch operands.
>>
>> No, it doesn't, you need to be careful. :-( ?I've reverted the problematic Ada
>> change for now. ?Jakub, would you mind re-testing with Ada? ?TIA.
>>
>
> I've just tested it and there are no regressions even with Ada[*].
>
> [*] The diff between vanilla r146995 bootstrap/regtest and the same with
> this patch is:
> -FAIL: ?c94008c
> -FAIL: ?c95021a
> -FAIL: ?c951002
> +FAIL: ?c940007
> (+ with the patch, - vanilla), but I've seen c940007 test fail in the past
> more than a dozen times, it fails pretty much randomly.
Indeed. We should add c940007 to norun.lst.
The patch is ok from my POV (but Jakub can approve it himself anyway).
Thanks,
Richard.