This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Don't add a new label for implicit default label if case labels cover the whole range (PR middle-end/39666)

From: Jakub Jelinek <jakub at redhat dot com>
To: Eric Botcazou <ebotcazou at adacore dot com>
Cc: Richard Guenther <richard dot guenther at gmail dot com>, gcc-patches at gcc dot gnu dot org
Date: Thu, 30 Apr 2009 10:59:04 +0200
Subject: Re: [PATCH] Don't add a new label for implicit default label if case labels cover the whole range (PR middle-end/39666)
References: <20090429214452.GQ5781@tyan-ft48-01.lab.bos.redhat.com> <20090429220634.GR5781@tyan-ft48-01.lab.bos.redhat.com> <84fc9c000904291509naeb3f6enf4c851d841aa6532@mail.gmail.com> <200904300113.23297.ebotcazou@adacore.com>
Reply-to: Jakub Jelinek <jakub at redhat dot com>

On Thu, Apr 30, 2009 at 01:13:22AM +0200, Eric Botcazou wrote:
> > Maybe Eric can confirm if gigi uses base types for switch operands.
> 
> No, it doesn't, you need to be careful. :-(  I've reverted the problematic Ada 
> change for now.  Jakub, would you mind re-testing with Ada?  TIA.
> 

I've just tested it and there are no regressions even with Ada[*].

[*] The diff between vanilla r146995 bootstrap/regtest and the same with
this patch is:
-FAIL:  c94008c
-FAIL:  c95021a
-FAIL:  c951002
+FAIL:  c940007 
(+ with the patch, - vanilla), but I've seen c940007 test fail in the past
more than a dozen times, it fails pretty much randomly.

	Jakub

Follow-Ups:
- Re: [PATCH] Don't add a new label for implicit default label if case labels cover the whole range (PR middle-end/39666)
  - From: Richard Guenther

References:
- [PATCH] Don't add a new label for implicit default label if case labels cover the whole range (PR middle-end/39666)
  - From: Jakub Jelinek
- Re: [PATCH] Don't add a new label for implicit default label if case labels cover the whole range (PR middle-end/39666)
  - From: Jakub Jelinek
- Re: [PATCH] Don't add a new label for implicit default label if case labels cover the whole range (PR middle-end/39666)
  - From: Richard Guenther
- Re: [PATCH] Don't add a new label for implicit default label if case labels cover the whole range (PR middle-end/39666)
  - From: Eric Botcazou

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]