This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch][plugins] Check the gcc version

From: Le-Chun Wu <lcwu at google dot com>
To: Richard Guenther <richard dot guenther at gmail dot com>
Cc: Rafael Espindola <espindola at google dot com>, Diego Novillo <dnovillo at google dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Wed, 29 Apr 2009 17:29:40 -0700
Subject: Re: [patch][plugins] Check the gcc version
References: <38a0d8450904141027n7452a92egb8bf7d61edafcd21@mail.gmail.com> <38a0d8450904270127t6178a615qaa4ebedf85b329e5@mail.gmail.com> <38a0d8450904270534i83655e3od9a58d606be5d2de@mail.gmail.com> <82091ad70904271931n6e7f19fdmcf0e42834c2b0811@mail.gmail.com> <38a0d8450904280348h51fc84f9wbfbbd15a0d5b18d7@mail.gmail.com> <82091ad70904281446i691799deh24c2b700c7056b6d@mail.gmail.com> <38a0d8450904290556h40e0c9cat442d228a8f3b8b1c@mail.gmail.com> <b798aad50904290613m16e4681eu74cbf981dc6efa45@mail.gmail.com> <38a0d8450904290621y676de6e6k3b32c79a3e01a995@mail.gmail.com> <84fc9c000904291214r7c16de3fg9255cfe6afe920a7@mail.gmail.com>

On Wed, Apr 29, 2009 at 12:14 PM, Richard Guenther
<richard.guenther@gmail.com> wrote:
> On Wed, Apr 29, 2009 at 3:21 PM, Rafael Espindola <espindola@google.com> wrote:
>>> Minor nit: No need to include generated files in patches.
>>
>> OK.
>>
>>> This needs changes in the testsuite patch, right? ?I'll take care of
>>> it on my local patch before I submit it to mainline.
>>
>> Yes. Good catch, should have warned you.
>
> This has broken bootstrap.
>
> See http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39968.
>

The bootstrap failure on the Darwin systems was caused by the
following warning/error:

./plugin-version.h:11: error: 'gcc_version' defined but not used

The sole use of gcc_version in plugin.c is in function
try_init_one_plugin, which is guarded by the macro ENABLE_PLUGIN.
Since ENABLE_PLUGIN is set to 0 on the Darwin systems, the function
was compiled out. Rafael, I think we need to guard the inclusion of
plugin-version.h with ENABLE_PLUGIN as well.

Le-chun

Follow-Ups:
- Re: [patch][plugins] Check the gcc version
  - From: Andrew Pinski
- Re: [patch][plugins] Check the gcc version
  - From: Rafael Espindola

References:
- [patch][plugins] Check the gcc version
  - From: Rafael Espindola
- Re: [patch][plugins] Check the gcc version
  - From: Rafael Espindola
- Re: [patch][plugins] Check the gcc version
  - From: Rafael Espindola
- Re: [patch][plugins] Check the gcc version
  - From: Le-Chun Wu
- Re: [patch][plugins] Check the gcc version
  - From: Rafael Espindola
- Re: [patch][plugins] Check the gcc version
  - From: Le-Chun Wu
- Re: [patch][plugins] Check the gcc version
  - From: Rafael Espindola
- Re: [patch][plugins] Check the gcc version
  - From: Diego Novillo
- Re: [patch][plugins] Check the gcc version
  - From: Rafael Espindola
- Re: [patch][plugins] Check the gcc version
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]