This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Hookize (partially) GO_IF_LEGITIMATE_ADDRESS
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: Paolo Bonzini <bonzini at gnu dot org>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 29 Apr 2009 20:22:38 +0100
- Subject: Re: [PATCH] Hookize (partially) GO_IF_LEGITIMATE_ADDRESS
- References: <20090423130523.GA26164@fencepost.gnu.org>
MIPS parts are OK, thanks, but...
Paolo Bonzini <bonzini@gnu.org> writes:
> Index: gcc/config/mips/mips.c
> ===================================================================
> --- gcc/config/mips/mips.c (revision 146581)
> +++ gcc/config/mips/mips.c (working copy)
> @@ -2122,7 +2122,7 @@ mips_classify_address (struct mips_addre
> /* Return true if X is a legitimate address for a memory operand of mode
> MODE. STRICT_P is true if REG_OK_STRICT is in effect. */
>
> -bool
> +static bool
> mips_legitimate_address_p (enum machine_mode mode, rtx x, bool strict_p)
> {
> struct mips_address_info addr;
...please change the comment to just:
/* Implement TARGET_LEGITIMATE_ADDRESS_P. */
(E.g. it seems better not to mention REG_OK_STRICT in this context
after the patch.)
Richard