This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix bootstrap fail on spu vs. ira.c/genpreds
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Vladimir Makarov <vmakarov at redhat dot com>
- Cc: Dave Korn <dave dot korn dot cygwin at googlemail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Ian Lance Taylor <iant at google dot com>
- Date: Mon, 27 Apr 2009 18:41:54 +0200
- Subject: Re: [PATCH] Fix bootstrap fail on spu vs. ira.c/genpreds
- References: <49F5C69B.8010206@gmail.com> <49F5CE9E.6020706@redhat.com> <49F5DEC9.9080605@gmail.com> <49F5DF24.5000800@redhat.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Mon, Apr 27, 2009 at 12:36:52PM -0400, Vladimir Makarov wrote:
>> Your solution is clean, but if anyone ever wants to call
>> regclass_for_constraint again in the future we might run into the same problem
>> again, might we not? I don't really mind which patch goes in, it's your call.
>>
>>
> There is a sense in your words too. So on the second thought, I'd go
> for your patch. Unfortunately for this case, I am not a maintainer of
> this part of compiler. So my ok is not an approval for committing the
> patch. I think Ian could do that. I am CCing the email to him.
Wouldn't it be better to just
#define regclass_for_constraint(x) NO_REGS
then in the generated header in that case?
Jakub