This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: GTY patch(attempt #2)


On Mon, Apr 20, 2009 at 21:07, Taras Glek <tglek@mozilla.com> wrote:

> ChangeLog entry:
> 2009-04-20 Taras Glek <tglek@mozilla.com>
> Â Â Â * Convert struct GTY attributes to be more like GNU attributes
>
> I'm attaching a single changelog entry and hoping that whoever lands this
> adds it to the correct ChangeLog[s].

Well, no.  You need to generate a proper ChangeLog for the whole
patch.  The CL entry you provided is not sufficient.  Sorry :)


> -	is_union = (token() == UNION);
> +    /* GTY annotations follow attribute syntax
> +       GTY_BEFORE_ID is for union/struct declarations
> +       GTY_AFTER_ID is for variable declarations */

End comment with '.  */'

> +        /* Unfortunately above GTY_TOKEN check does not capture the
> +           typedef struct_type GTY case */

Likewise.

> +        if (token () == '{')
> +          {
> +            if (is_gty == GTY_AFTER_ID)
> +              {
> +                parse_error ("GTY must be specified before identifier\n");
> +              }

No need to use braces for a single line.  Also, no '\n' at the
end of the error string.

The rest of the patch looks mind-numbingly OK.


Diego.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]