Re: [PATCH] Hookize LEGITIMIZE_ADDRESS

[Richard Sandiford <rdsandiford at googlemail dot com>]

Thanks for doing this!

"Joseph S. Myers" <joseph@codesourcery.com> writes:
> On Fri, 17 Apr 2009, Paolo Bonzini wrote:
>
>> +@deftypefn {Target Hook} rtx LEGITIMIZE_ADDRESS (rtx @var{x}, rtx @var{oldx}, enum machine_mode @var{mode})
>
> The hook is TARGET_LEGITIMIZE_ADDRESS, not LEGITIMIZE_ADDRESS.

Same thing in the MIPS comment.  Also:

-/* This function is used to implement LEGITIMIZE_ADDRESS.  If *XLOC can
+/* This function is used to implement LEGITIMIZE_ADDRESS.  If X can
    be legitimized in a way that the generic machinery might not expect,
-   put the new address in *XLOC and return true.  MODE is the mode of
+   return a new address, otherwise return NULL.  MODE is the mode of
    the memory being accessed.  */

s/otherwise return NULL/otherwise return X/.  Although now that this
function has a standard interface -- rather than being an internal
implementation of a standard macro -- plain:

/* Implement TARGET_LEGITIMIZE_ADDRESS.  */

is probably better.  The MIPS parts are OK with that change.

Richard