Re: Remove arm-*-* from target of test _Pragma1.C and _Pragma6.c?

[Ramana Radhakrishnan <ramana dot r at gmail dot com>]

On Fri, Apr 17, 2009 at 10:38 PM, Jing Yu <jingyu@google.com> wrote:
> On Thu, Apr 16, 2009 at 2:47 PM, Ramana Radhakrishnan
> <ramana.r@gmail.com> wrote:
>> Just defining it should work fine. I don't know of any reason why this
>> shouldn't be supported. Thanks for offering to put it in and test it
>
> I defined HANDLE_PRAGMA_PACK_PUSH_POP in arm.h and did dejagnu gcc and
> g++ test again.
>
> Configured with: /home/jingyu/projects/gcc/gcc_trunk/configure
> --prefix=/home/jingyu/projects/gcc/obj-arm_eabi2/install
> --target=arm-eabi --build=i686-linux --host=i686-linux
> --with-gmp=/home/jingyu/projects/gcc/obj-arm_eabi2/install
> --with-mpfr=/home/jingyu/projects/gcc/obj-arm_eabi2/install
> --enable-multilib --with-newlib --with-gnu-as --with-gnu-ld
> --enable-languages=c,c++
> Thread model: single
> gcc version 4.5.0 20090417 (experimental) (GCC)
>
> The only difference is that
> g++.dg/cpp/_Pragma1.C and gcc.dg/cpp/_Pragma6.c become 'pass'.
>
> The attachment is the patch to add the definition.
>
> ? ? ?* config/arm/arm.h: Define HANDLE_PRAGMA_PACK_PUSH_POP.
>
> Is it ok for trunk and GCC-4.4 branch?

I see that you've filed
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39781 for this. Please
refer the necessary PR in your ChangeLog entry as PR target/39781.

I can't approve the patch but I have a couple of comments about the
patch. I've CC'd one of the maintainers of the ARM backend for his
approval.

Please put a copy of the ChangeLog entry in your email and not make
the ChangeLog a part of your patch.


+
+/* Define this so we can compile MS code for use with WINE.  */

I'd reword this to remove references to WINE or MS.

Something of the form - "Define this for compatibility reasons." might
be better.


Thanks -
Ramana