This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] fix PR39701 testsuite failures
On Fri, Apr 10, 2009 at 4:39 PM, Ian Lance Taylor <iant@google.com> wrote:
> Richard Guenther <richard.guenther@gmail.com> writes:
>
>> On Fri, Apr 10, 2009 at 9:17 AM, Paolo Bonzini <bonzini@gnu.org> wrote:
>>
>>> ?Observation: I think however that it does not make sense to have
>>> ?-fdelete-null-pointer-checks only at -O2 or higher -- it it is not
>>> ?an optimization option, rather it describes the semantics of the
>>> ?target, and it should be enabled uniformly at all optimization levels.
>>> ?If there are places that we consider optimizations, they should be
>>> ?guarded by "(optimize >= 2 && flag_delete_null_pointer_checks).
>>
>> I agree. ?A patch to make -fdelete-null-pointer-checks enabled by
>> default is pre-approved (it likely needs documentation changes).
>
> At -O0, if I write
> ? ?if (&i == 0) abort();
> then I need to be able to set a breakpoint on that line. ?I'm OK with
> the patch if that property is preserved.
The patch would not change this - the last patch introduced the
flag_delete_null_pointer_checks check, before it we always optimized
the above.
Richard.
> Ian
>