PR c/c++/16202 The -Wsequence-point warning misses many important instances

[Manuel López-Ibáñez <lopezibanez at gmail dot com>]

Updated to a recent revision, bootstrapped and regression tested on
x86_64-unknown-linux-gnu with --enable-languages=all

OK for trunk?

2009-04-10  Manuel López-Ibáñez  <manu@gcc.gnu.org>

	PR 16202
	* c-typeck.c (lvalue_p): Move declaration ...
	* c-common.h (lvalue_p): ... to here.
	* c-common.c (candidate_equal_p): New.
	(add_tlist): Use it.
	(merge_tlist): Use it.
	(warn_for_collisions_1): Likewise.
	(warning_candidate_p): Accept more candidates.
	(verify_tree): A warning candidate can be an expression. Use
	candidate_equal_p.
cp/
	* tree.c (lvalue_p_1): Use const_tree.
	Use CONST_CAST_TREE to avoid warning.
	(lvalue_p): Returns bool, receives const_tree.
	
testsuite/
	* gcc.dg/sequence-pt-1.c: Remove XFAILs.
	* gcc.dg/sequence-pt-2.c: New.
	* gcc.dg/sequence-pt-3.c: New.
	* g++.dg/warn/sequence-pt-1.C: Remove XFAILs.
	* g++.dg/warn/sequence-pt-2.c: New.
	* g++.dg/warn/sequence-pt-3.c: New.
	


2008/10/24 Manuel López-Ibáñez <lopezibanez@gmail.com>:
> The idea behind this patch was proposed by Tom Truscott. It fixes many
> (all?) cases where -Wsequence-points failed.
>
> I am submitting this now in case anyone wants to comment and to have
> link from bugzilla.
>
> Bootstrapped and regression tested on x86_64-unknown-linux-gnu with
> --enable-languages=all
>
> 2008-10-24 ?Manuel López-Ibáñez ?<manu@gcc.gnu.org>
>
> ? ? ? ?PR 16202
> ? ? ? ?* c-typeck.c (lvalue_p): Move declaration ...
> ? ? ? ?* c-common.h (lvalue_p): ... to here.
> ? ? ? ?* c-common.c (candidate_equal_p): New.
> ? ? ? ?(add_tlist): Use it.
> ? ? ? ?(merge_tlist): Use it.
> ? ? ? ?(warn_for_collisions_1): Likewise.
> ? ? ? ?(warning_candidate_p): Accept more candidates.
> ? ? ? ?(verify_tree): A warning candidate can be an expression. Use
> ? ? ? ?candidate_equal_p.
> testsuite/
> ? ? ? ?* gcc.dg/sequence-pt-1.c: Remove XFAILs.
> ? ? ? ?* gcc.dg/sequence-pt-2.c: New.
> ? ? ? ?* gcc.dg/sequence-pt-3.c: New.
> ? ? ? ?* g++.dg/warn/sequence-pt-1.C: Remove XFAILs.
> ? ? ? ?* g++.dg/warn/sequence-pt-2.c: New.
> ? ? ? ?* g++.dg/warn/sequence-pt-3.c: New.
>

Attachment: fix-pr16202.diff
Description: Text document