This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][SH] Multilib selection rework


Hello Andrew,

I'm not *really* sure whether there is an actual relevant problem, but I
think you may need to quote the exclamation marks.  The Autoconf
manual has this in the Shell Portability Section:

|    On some Posix-like platforms, `!' and `^' are special too, so they
| should be avoided.

In any case quoting should not hurt.

* Andrew Stubbs wrote on Tue, Apr 07, 2009 at 06:35:30PM CEST:
> --- src/gcc-mainline/gcc/config.gcc.orig
> +++ src/gcc-mainline/gcc/config.gcc

> +		!*)	# TM_MULTILIB_EXCEPTIONS_CONFIG is used by t-sh

Quoting within shell 'case' patterns should be done with a backslash.

> +			# It is passed the MULTILIB_EXCEPTIONS verbatim.
> +			TM_MULTILIB_EXCEPTIONS_CONFIG="${TM_MULTILIB_EXCEPTIONS_CONFIG} `echo $sh_multilib | sed 's/^!//'`" ;;

> --- src/gcc-mainline/gcc/config/sh/t-sh.orig
> +++ src/gcc-mainline/gcc/config/sh/t-sh

> +MULTILIB_OSDIRNAMES = \
> +	$(OTHER_ENDIAN)=!$(OTHER_ENDIAN) \

Here I guess you can just use single or double quotes.

> +	m1=!m1 $(OTHER_ENDIAN)/m1=!$(OTHER_ENDIAN)/m1 \
[...]

Cheers,
Ralf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]