This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFA [PR objc/29200][diagnostic] Make diagnostics translation friendly
Thank you Mike!
Am Donnerstag, den 02.04.2009, 18:50 -0700 schrieb Mike Stump:
> On Apr 2, 2009, at 6:05 PM, David Ayers wrote:
> > I've verified that currently all calls of warn_with_method supply a
> > constant string as the message parameter so that the translation can
> > be
> > called from within warn_with_method.
>
> For the objc bits, Ok. For the translation bits, gosh, be nice to
> have someone in the know verify this; I'm not up all all the little
> rules. I think it's ok.
CC'ing i18n maintainers:
This is a diagnostics bug fix to improve the ability to translate
certain strings in the Objective-C frontend. Certain strings are being
constructed in a local function:
static void
warn_with_method (const char *message, int mtype, tree method)
{
/* Add a readable method name to the warning. */
warning (0, "%J%s %<%c%s%>", method,
_(message), mtype, gen_method_decl (method));
}
The _() around MESSAGE is introduced by this patch. To repeat the quite
above: I've verified that currently all calls to warn_with_method supply
a constant string as the message parameter so that the translation can
be called from within warn_with_method.
http://gcc.gnu.org/ml/gcc-patches/2009-04/msg00226.html
Is this OK from i18n maintainer POV for the trunk (when the trunk
unfreezes after the a-i merge)?
Cheers,
David
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29200