This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[trunk][patch] Remove unnecessary calls to assemble_external
- From: Rafael Espindola <espindola at google dot com>
- To: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Cc: Diego Novillo <dnovillo at google dot com>
- Date: Thu, 2 Apr 2009 08:50:15 +0100
- Subject: [trunk][patch] Remove unnecessary calls to assemble_external
Tested with a bootstrap and a regression test on linux 86-64.
Currently testing on darwin ppc.
OK for trunk if both are OK?
2009-04-01 Rafael Avila de Espindola <espindola@google.com>
* class.c (build_vtbl_ref_1): Remove call to assemble_external.
* init.c (build_vtbl_address): Remove call to assemble_external.
Cheers,
--
Rafael Avila de Espindola
Google | Gordon House | Barrow Street | Dublin 4 | Ireland
Registered in Dublin, Ireland | Registration Number: 368047
diff --git a/gcc/cp/class.c b/gcc/cp/class.c
index b8553ef..8f9e577 100644
--- a/gcc/cp/class.c
+++ b/gcc/cp/class.c
@@ -625,7 +625,6 @@ build_vtbl_ref_1 (tree instance, tree idx)
if (!vtbl)
vtbl = build_vfield_ref (instance, basetype);
- assemble_external (vtbl);
aref = build_array_ref (vtbl, idx, input_location);
TREE_CONSTANT (aref) |= TREE_CONSTANT (vtbl) && TREE_CONSTANT (idx);
diff --git a/gcc/cp/init.c b/gcc/cp/init.c
index 8e3e489..812042d 100644
--- a/gcc/cp/init.c
+++ b/gcc/cp/init.c
@@ -869,7 +869,6 @@ build_vtbl_address (tree binfo)
/* Figure out what vtable BINFO's vtable is based on, and mark it as
used. */
vtbl = get_vtbl_decl_for_binfo (binfo_for);
- assemble_external (vtbl);
TREE_USED (vtbl) = 1;
/* Now compute the address to use when initializing the vptr. */