This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [atom]: PATCH: reg_mentioned_by_mem_p with DF
On Mon, Mar 30, 2009 at 12:32 PM, Paolo Bonzini <bonzini@gnu.org> wrote:
> Steven Bosscher wrote:
>> On Mon, Mar 30, 2009 at 9:07 AM, Jakub Jelinek <jakub@redhat.com> wrote:
>>> On Mon, Mar 30, 2009 at 02:43:52PM +0800, Ye, Joey wrote:
>>>> Reimplement reg_mentioned_by_mem_p with DF, after Steven's
>>>> comments.
>>>>
>>>> Thanks - Joey
>>>>
>>>> ? ? * rtlanal.c (reg_mentioned_by_mem_p_1): Removed.
>>>> ? ? (reg_mentioned_by_mem_p): Re-implement with DF.
>>> As it is used by insn splitter and splitting can also happen during final
>>> when DF isn't available, I don't see how this is a safe thing to do.
>>
>> Why do you think DF is not available in final?
>
> I don't remember exactly, but I think Jakub is right. ?I don't think DF
> is kept up to date by the last passes, especially after BLOCK_FOR_INSN
> is unset.
As far as I know, the df-scan info is also OK in final. But I may be wrong.
The question is then: Which is wrong? That DF is not available, or the
patch? I vote "the patch".
Ciao!
Steven