This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] rs6000_macro_to_expand fix


This is okay for trunk and 4.4.

I was hoping that Ben would comment on this and the other patch you pinged.

David

On Sat, Mar 28, 2009 at 12:44 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Fri, Mar 27, 2009 at 12:00:26PM +0100, Jakub Jelinek wrote:
>> While looking at PR39558, I've noticed that the following testcase is
>> preprocessed incorrectly. ?In -E output there is always vectorpixel int ...
>> or vectorbool int ..., when compiling neither vector nor bool/pixel
>> are expanded and so it fails to parse.
>>
>> Fixed thusly, ok for trunk (this is a bug in a new 4.4 feature)?
>
> FYI, bootstrapped/regtested on powerpc{,64}-linux (both -m32 and -m64).
>
> BTW, it is actually a regression from 4.3 (it is enough to add
> #include <altivec.h>
> to the beginning of the testcase, with 4.3 it compiles just fine, with 4.4
> it doesn't parse, so ok for both trunk and 4.4?
>
>> 2009-03-27 ?Jakub Jelinek ?<jakub@redhat.com>
>>
>> ? ? ? * config/rs6000/rs6000-c.c (rs6000_macro_to_expand): If macro
>> ? ? ? following vector keyword has expansion starting with pixel or bool
>> ? ? ? keyword, expand vector to __vector and pixel or bool to __pixel or
>> ? ? ? __bool.
>>
>> ? ? ? * gcc.target/powerpc/altivec-28.c: New test.
>
> ? ? ? ?Jakub
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]