This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PR c++/35652 [4.2/4.3/4.4 Regression] offset warning should be given in the front-end
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Manuel López-Ibáñez <lopezibanez at gmail dot com>
- Cc: Gcc Patch List <gcc-patches at gcc dot gnu dot org>, Paolo Bonzini <bonzini at gnu dot org>
- Date: Fri, 27 Mar 2009 07:43:25 -0700
- Subject: Re: PR c++/35652 [4.2/4.3/4.4 Regression] offset warning should be given in the front-end
- References: <6c33472e0811030736i272ea3a9r996e4b5a5fd3b3c7@mail.gmail.com> <6c33472e0902051953p6153aba7se1d5c9200fb25c4a@mail.gmail.com>
On Fri, Feb 06, 2009 at 04:53:10AM +0100, Manuel López-Ibáñez wrote:
> + else
> + offset = tree_low_cst (offset_node, 0);
> +
> + offset = offset + tree_low_cst (intop, 0);
> + if (offset < 0 || offset > max)
> + warning_at (location, 0,
> + "offset %<%ld%> outside bounds of constant string",
> + tree_low_cst (intop, 0));
> + }
> + }
> +
tree_low_cst returns HOST_WIDE_INT. We need HOST_WIDE_INT_PRINT_DEC
insted of %ld. I am checking in this patch.
H.J.
----
Index: ChangeLog
===================================================================
--- ChangeLog (revision 145107)
+++ ChangeLog (working copy)
@@ -1,3 +1,8 @@
+2009-03-27 H.J. Lu <hongjiu.lu@intel.com>
+
+ * c-common.c (pointer_int_sum): Use HOST_WIDE_INT_PRINT_DEC
+ on return from tree_low_cst.
+
2009-03-27 Andrew Pinski <andrew_pinski@playstation.sony.com>
PR c++/36799
Index: c-common.c
===================================================================
--- c-common.c (revision 145107)
+++ c-common.c (working copy)
@@ -3315,8 +3315,8 @@ pointer_int_sum (location_t location, en
offset = offset + tree_low_cst (intop, 0);
if (offset < 0 || offset > max)
- warning_at (location, 0,
- "offset %<%ld%> outside bounds of constant string",
+ warning_at (location, 0, "offset %<" HOST_WIDE_INT_PRINT_DEC
+ "%> outside bounds of constant string",
tree_low_cst (intop, 0));
}
}