This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] win64 fix for libiberty md5.h


"O.Sezer" <sezeroz@gmail.com> writes:

> --- a/include/md5.h	2008-03-25 02:19:55.000000000 +0200
> +++ a/include/md5.h	2009-01-30 11:25:50.000000000 +0200
> @@ -69,8 +69,12 @@ typedef uintptr_t md5_uintptr;
>  # endif
>  /* We have to make a guess about the integer type equivalent in size
>     to pointers which should always be correct.  */
> +#ifdef _WIN64
> +typedef unsigned long long md5_uintptr;
> +#else
>  typedef unsigned long int md5_uintptr;
>  #endif
> +#endif

I appreciate that there is a real problem here, but I would like to find
a solution which does not involve sprinkling #ifdefs around.  We already
have one in include/splay-tree.h which I would like to eliminate.

Does _WIN64 provide a useful definition of uintptr_t?  Also, note that
the comment in md5.h saying that AC_CHECK_SIZEOF can not be used is out
of date.  With current versions of autoconf, AC_CHECK_SIZEOF works even
when cross-compiling.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]