RE: [PATCH] SMS - Pass the actual schedulable rows to compute_split_row

["Bingfeng Mei" <bmei at broadcom dot com>]

Revital and Ayal,
OK. I tested on my target. II is reduced by 1 for sms-6.c, which is good. 

Bingfeng Mei
Broadcom UK

> -----Original Message-----
> From: Revital1 Eres [mailto:ERES@il.ibm.com] 
> Sent: 13 March 2009 05:50
> To: Ayal Zaks
> Cc: Adrian Ashley; Bingfeng Mei; gcc@gcc.gnu.org; 
> gcc-patches@gcc.gnu.org
> Subject: [PATCH] SMS - Pass the actual schedulable rows to 
> compute_split_row
> 
> Hello,
> 
> > > Using testsuite/gcc.dg/sms-6.c as an example and compiling it for
> > PowerPC,
> > > node 18 (see attachment) is in a SCC and cannot be scheduled until
> > spliting
> > > twice. The MII = 20 and the schedule can only  be found 
> at II = 24.
> >
> > Yes, I see. This example raises a couple of issues:
> >
> > o The first row split (from II=20 to II=21) is 
> miscalculated; it should
> be
> > row 20=0 instead of 19. Splitting row 19 cannot help 
> schedule node 18,
> and
> > indeed we immediately split another row. We're now checking 
> a small patch
> > to fix this, which should save one cycle of II in the above example.
> 
> Here is the patch, on behalf of Ayal.
> Passed bootstrap + regtest with SMS flags on ppc64 and bootstrap +
> regtest x86.
> 
> I'll commit it later today to trunk if that's OK.
> 
> Thanks,
> Revital
> 
>         * modulo-sched.c (sms_schedule_by_order): Pass the actual
>         schedulable rows to compute_split_row.
> 
> (See attached file: patch_sms_12_3.txt)