This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] PR libobjc/27466 unexpected exception handler V2


Am Mittwoch, den 11.03.2009, 18:14 +0100 schrieb Nicola Pero:
> >> this patch is approved.
> >> As far as I'm concerned, I recommend adding this tiny bug fix to GCC
> >> 4.3 too if it's not too late - it would avoid
> >> shipping a broken GNU Objective-C exception handling support in
> >> libobjc, and has zero impact on everything else,
> >> so it's a safe but very useful bug fix for libobjc.
> >
> > OK, I'm a bit confused since we usually commit fixes to the trunk  
> > before
> > we backport them to a branch, and the eminent release is 4.4 where as
> > you say this OK for 4.3 branch.
> 
> I did obviously mean 4.4.  Sorry about that.

Thanks! Committed.

I also took the freedom to update the copyright dates in the respective
files.

I'll commit to the 4.3 branch tomorrow, save any vetos.

Cheers,
David

> 
> >> PS: It would be good if you could also provide a second patch which
> >> expands the "Hook for uncaught exceptions"
> >> comment in the public header into a couple of readable sentences. ;-)
> >
> > This is what I'll add:
> >
> > "This hook is called when a exception is thrown when no valid  
> > exception
> > handler is in place.  If the function returns the result is currently
> > undefined."
> 
> Sounds good.
> 
> I like your idea of explicitly saying that the result is currently  
> undefined since
> we want to be free to define it in future/forthcoming releases of GCC/ 
> libobjc
> (eg, to allow recovering from uncaught exceptions in some cases). :-)
> 
> But to make it a bit less cryptic as it stands, I would suggest we go  
> for
> 
> > "This hook is called when a exception is thrown when no valid  
> > exception
> > handler is in place.  The function is normally expected to never  
> > return.
> > If the function returns the result is currently undefined."
> 

Done (with minor tweaks).



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]