Re: [PATCH 4.5]: Fix PR39146 unneccesary stack realign

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Mon, Mar 2, 2009 at 10:10 PM, Ye, Joey <joey.ye@intel.com> wrote:
> Update testcase. OK for 4.5?
>
> Thanks - Joey
>
> -----Original Message-----
> From: H.J. Lu [mailto:hjl.tools@gmail.com]
> Sent: Monday, March 02, 2009 11:17 PM
> To: Ye, Joey
> Cc: GCC Patches
> Subject: Re: [PATCH 4.5]: Fix PR39146 unneccesary stack realign
>
> Hi Joey,
>
> It is too late for 4.4. ?We are submitting it for gcc 4.5.
>
> On Sun, Mar 1, 2009 at 11:42 PM, Ye, Joey <joey.ye@intel.com> wrote:
>> Refer to http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39146
>>
>> gcc/ChangeLog:
>> 2009-03-01 ?Joey Ye ?<joey.ye@intel.com>
>>
>> ? ? ? ?PR middle-end/39146
>> ? ? ? ?* cfgexpand.c (get_decl_align_unit): Update
>> ? ? ? ?max_used_stack_slot_alignment with align instead of
>> ? ? ? ?stack_alignment_needed.
>>
>> ? ? ? ?* function.c (assign_stack_local_1): Update
>> ? ? ? ?max_used_stack_slot_alignment with alignment_in_bits instead
>> ? ? ? ?of stack_alignment_needed.
>> ? ? ? ?(locate_and_pad_parm): Don't update max_used_stack_slot_alignment
>> ? ? ? ?here.
>>
>> Modified:
>> ? ?branches/stack/gcc/cfgexpand.c
>> ? ?branches/stack/gcc/function.c
>>
>> testsuites/ChangeLog:
>> 2009-03-01 ?H.J. Lu ?<hongjiu.lu@intel.com>
>>
>> ? ? * gcc.target/i386/avx-m256-align.c: New testcase.
>
> Please move it to gcc.target/i386/stackalign and remove

I think this test belongs to gcc.target/i386/stackalign. But
it isn't that important.

>
> /* { dg-require-effective-target lp64 } */

You didn't remove this. This test should be run for 32bit.

> You can use
>
> /* { dg-final { scan-assembler-not "and\[lq\]?\[\\t \]*\\$-32,\[\\t
> \]*%\[re\]?sp" } } */
>
>

I think

/* { dg-final { scan-assembler-not "and\[lq\]?\[^\\n\]*-32,\[^\\n\]*sp" } } */

will work for Windows.

Thanks.

-- 
H.J.