This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: PR target/39327: Incorrect addsub/unpck patterns in sse.md
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Uros Bizjak <ubizjak at gmail dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Joey Ye <joey dot ye at intel dot com>, Xuepeng Guo <xuepeng dot guo at intel dot com>
- Date: Sat, 28 Feb 2009 14:23:58 -0800
- Subject: Re: PATCH: PR target/39327: Incorrect addsub/unpck patterns in sse.md
- References: <20090228183945.GA1055@lucon.org> <49A9A5D3.1040405@gmail.com>
On Sat, Feb 28, 2009 at 1:00 PM, Uros Bizjak <ubizjak@gmail.com> wrote:
> H.J. Lu wrote:
>>
>> Some addsub/unpck patterns have wrong item selectors. This patch
>> fixes. ?OK for trunk if there are no regressions on Linux/ia32 and
>> Linux/Intel64?
>>
>> Thanks.
>>
>>
>> H.J.
>> ----
>> 2009-02-28 ?H.J. Lu ?<hongjiu.lu@intel.com>
>>
>> ? ? ? ?PR target/39327
>> ? ? ? ?* config/i386/sse.md (avx_addsubv8sf3): Correct item bits.
>> ? ? ? ?(avx_addsubv4df3): Likewise.
>> ? ? ? ?(*avx_addsubv4sf3): Likewise.
>> ? ? ? ?(sse3_addsubv4sf3): Likewise.
>> ? ? ? ?(*avx_addsubv2df3): Likewise.
>> ? ? ? ?(sse3_addsubv2df3): Likewise.
>> ? ? ? ?(avx_unpckhps256): Correct item selectors.
>> ? ? ? ?(avx_unpcklps256): Likewise.
>> ? ? ? ?(avx_unpckhpd256): Likewise.
>> ? ? ? ?(avx_unpcklpd256): Likewise.
>>
>
> OK for 4.4 and 4.3. ?These numbers are tricky, I hope you are sure that they
> are correct ;)
>
There are extra failures after I fixed:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39315
That is how I noticed them. I am checking it into trunk and will backport SSE3
fix to 4.3 in a few days.
Thanks.
--
H.J.