Re: PATCH: PR rtl-optimization/39241: [4.4 Regression] ICE in subreg_get_info, at rtlanal.c:3104

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Thu, Feb 19, 2009 at 5:20 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Wed, Aug 6, 2008 at 7:12 AM, Ian Lance Taylor <iant@google.com> wrote:
>> "Joseph S. Myers" <joseph@codesourcery.com> writes:
>>
>>> 2008-08-02  Joseph Myers  <joseph@codesourcery.com>
>>>
>>>       * jump.c (rtx_renumbered_equal_p): Do not call subreg_regno_offset
>>>       for unrepresentable subregs or treat them as equal to other regs
>>>       or subregs with the same register number.
>>
>> This is OK.
>>
>> Thanks.
>>
>
> This patch may call subreg_offset_representable_p on pseudo registers,
> which causes ICE, as shown in
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39241
>
> OK for trunk if no regressions on Linux/ia32, Linux/ia64 and Linux/x86-64?
>
> Thanks.
>
>
> --
> H.J.
> ---
> gcc/
>
> 2008-02-19  H.J. Lu  <hongjiu.lu@intel.com>
>
>        PR rtl-optimization/39241
>        * jump.c (rtx_renumbered_equal_p): Call subreg_offset_representable_p
>        only for hard registers.
>
>
> gcc/testsuite/
>
> 2008-02-19  H.J. Lu  <hongjiu.lu@intel.com>
>
>        PR rtl-optimization/39241
>        * gcc.dg/torture/pr39241.c: New.
>

Here is the updated version. It replaces 2 calls to
subreg_offset_representable_p and subreg_regno_offset
with one call to subreg_get_info.

-- 
H.J.
---
gcc/

2008-02-19  H.J. Lu  <hongjiu.lu@intel.com>

	PR rtl-optimization/39241
	* jump.c (rtx_renumbered_equal_p): Use subreg_get_info.  Call
	subreg_offset_representable_p only for hard registers.

	* rtlanal.c (subreg_info): Moved to ...
	* rtl.h (subreg_info): Here.  New.
	(subreg_get_info): New.

	* rtlanal.c (subreg_get_info): Make it extern.

gcc/testsuite/

2008-02-19  H.J. Lu  <hongjiu.lu@intel.com>

	PR rtl-optimization/39241
	* gcc.dg/torture/pr39241.c: New.

Attachment: gcc-pr39241-2.patch
Description: Text document