This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [lto] Fix memory access


On Mon, Feb 16, 2009 at 12:16, Rafael Espindola <espindola@google.com> wrote:

>  /* Read the string at LOC from the string table in DATA_IN.  */
>
> -static const char *
> -input_string_internal (struct data_in *data_in, unsigned int loc,
> +static const char *
> +input_string_internal (struct data_in *data_in, struct lto_input_block *ib,
>  		       unsigned int *rlen)

Comment needs updating.

>  /* Read a STRING_CST at LOC from the string table in DATA_IN.  */
>
>  static tree
> -input_string (struct data_in *data_in, unsigned int loc)
> +input_string_cst (struct data_in *data_in, struct lto_input_block *ib)

Likewise.

>
> +static tree
> +input_identifier (struct data_in *data_in, struct lto_input_block *ib)
> +{

Needs comment.

> +
> +static const char *
> +input_string (struct data_in *data_in, struct lto_input_block *ib)
> +{

Needs comment.

OK with those changes.


Diego.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]