Re: [PATCH] Uglify gthr*.h function parameter and local variable names

[Benjamin Kosnik <bkoz at redhat dot com>]

The following patch uglifies what needs to be uglified in gthr*.h
(doesn't uglify _LIBOBJC specific bits, as libobjc doesn't care).
Ok for trunk if testing succeeds (all I care about and can test is
gthr-posix.h, the rest I''ve just skimmed)?

Definitely, this sounds great.

BTW, I've instrumented cc1plus a little bit to report me non-uglified
function parameter names and local variables in inlines, attached is a list
(maybe incomplete, haven't tried all the various feature test macros and
-std= options) of the [a-z].* named parameters or local variables in
libstdc++ and glibc headers (and a couple of kernel headers that got
included by those).  I think libstdc++ appendix_contributing.xml says
that such names should be uglified with __ prefix (while avoiding
thread -> __thread), is this something we should eventually fix as well?

Yes.

-benjamin