This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C/C++ PATCH] Call make_decl_rtl in {,c_}determine_visibility if DECL_RTL is set and visibility changed (PR target/39175)
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Joseph Myers <joseph at codesourcery dot com>, Jason Merrill <jason at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Fri, 13 Feb 2009 16:39:19 -0800
- Subject: Re: [C/C++ PATCH] Call make_decl_rtl in {,c_}determine_visibility if DECL_RTL is set and visibility changed (PR target/39175)
- References: <20090213210617.GI28939@tyan-ft48-01.lab.bos.redhat.com>
Jakub Jelinek wrote:
> After this make_decl_rtl is called, determines the function binds locally and
> sets SYMBOL_FLAG_LOCAL|SYMBOL_FLAG_FUNCTION.
In general, it's unpleasant to change the RTL for a DECL after it's been
created. We do it, but it's a wart. Really, we should wait until we
have enough information to commit, and then generate the RTL once. Is
it essential that we create the RTL this early?
Thanks,
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713