Re: Ping: patch to remove the old RA

[Vladimir Makarov <vmakarov at redhat dot com>]

H.J. Lu wrote:
> On Wed, Jan 28, 2009 at 2:12 PM, Vladimir Makarov <vmakarov@redhat.com> wrote:
>   
> > The original patches were posted on
> >
> > http://gcc.gnu.org/ml/gcc-patches/2008-12/msg00613.html
> > http://gcc.gnu.org/ml/gcc-patches/2008-12/msg00741.html
> >
> > I am sending an updated version of the patch here because a few recent IRA
> > patches resulted in the patch updates too.
> >
> >  * Makefile.in (RA_H): Remove.
> >     
>
> Is ra.h still being used? If not, can we remove ra.h now?
>
>   
Yes, we can.  I missed that too.  It was a header for communication 
between ra-conflict.c and global.c.
> Also ira-color.c has
>
> /* Try to assign a hard register (except for FORBIDDEN_REGS) to
>    allocno A and return TRUE in the case of success.  That is an
>    analog of retry_global_alloc for IRA.  */
> static bool
> allocno_reload_assign (ira_allocno_t a, HARD_REG_SET forbidden_regs)
>
> Since retry_global_alloc is gone, this comment should be
> updated.
>
>   
Yes, that is right.  The last sentence should be removed.  Thanks for 
finding all of this, H.J.  Removing the old RA is a big change and 
probably there are still some comments or even code which should be changed.