This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix -ftree-loop-distribution (PR tree-optimization/39007)


On Thu, Jan 29, 2009 at 10:08 AM, Kazu Hirata <kazu@codesourcery.com> wrote:
> The patch fixes the problem with:
>
>  set_immediate_dominator (CDI_DOMINATORS, dest,
>                           recompute_dominator (CDI_DOMINATORS, dest));
>
> Basic blocks for the loop are removed, so DEST should be the only
> basic block we need to update the immediate dominator of.
>

The patch looks good, but I cannot approve.

> Tested on x86_64-pc-linux-gnu.  OK to apply?
>
> Kazu Hirata
>
> 2009-01-29  Kazu Hirata  <kazu@codesourcery.com>
>
>        PR tree-optimization/39007
>        * tree-loop-distribution.c (generate_memset_zero): Use
>        POINTER_PLUS_EXPR for a pointer addition.

This changelog entry should be something different...

Thanks for fixing this,
Sebastian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]