This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[patch, testsuite] Remove bad test gcc.dg/pr35729.c
- From: Steve Ellcey <sje at cup dot hp dot com>
- To: gcc-patches at gcc dot gnu dot org, rakdver at gcc dot gnu dot org
- Date: Wed, 21 Jan 2009 11:05:38 -0800 (PST)
- Subject: [patch, testsuite] Remove bad test gcc.dg/pr35729.c
- Reply-to: sje at cup dot hp dot com
I would like to propose removing the test gcc.dg/pr35729.c. The bug
reported by 35729 has been fixed and seems to be fine but the test that
was added for it is failing on multiple systems.
The code change that this test is checking is to make sure that we do
not hoist assigments from volatile variables out of a loop and the test
tries to check this by checking that we do not see 'Decided to move
invariant' in the dump loop-invariant dump file, the problem is that
there are invariant statements that can and do get hoisted out of the
loop so we see this statement in the dump file and fail the test.
The information in the dump file does not seem to be specific enough
about what is and is not being hoisted out of the loop to be able to
verify that only the assignment of interest is not being hoisted.
Trying to modify the dump file output so one could scan for something
involving the variable in question would be much more work than the very
simple bug fix that went in.
This bug is assigned to Zdenek Dvorak and he created the test case but I
haven't seen any email from him to the GCC email lists since before
Christmas.
So I would just like to remove this test.
OK for checkin?
Steve Ellcey
sje@cup.hp.com
2009-01-21 Steve Ellcey <sje@cup.hp.com>
PR rtl-optimization/35729
* gcc.dg/pr35729.c: Remove.