This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, darwin] repost of a patch to make -static-libgfortan work.


On Mon, 2009-01-19 at 19:25 -0500, Jack Howarth wrote:
> On Mon, Jan 19, 2009 at 04:05:10PM -0800, Janis Johnson wrote:
> > On Fri, 2009-01-16 at 20:55 -0500, Jack Howarth wrote:
> > >    Iain's patch from...
> > > 
> > > http://gcc.gnu.org/ml/gcc-patches/2008-12/msg01328.html
> > > 
> > > has been approved...
> > > 
> > > http://gcc.gnu.org/ml/gcc-patches/2009-01/msg00356.html
> > > http://gcc.gnu.org/ml/gcc-patches/2009-01/msg00382.html
> > > 
> > > I have created a clean diff against current gcc trunk for
> > > it and added the missing changelog. It works fine under
> > > i686-apple-darwin9 for creating staticly linked fortran
> > > binaries.
> > >     Janis, could you please do the checkin so we can get
> > > this in before the branch occurs. Thanks in advance.
> > >                Jack
> > > 
> > > 2009-01-16  Iain Sandoe  <iain.sandoe@sandoe-acoustics.co.uk>
> > > 
> > >         * gcc/config/darwin.h: Add static-libgfortran to LINK_SPEC.
> > >         * libgomp/testsuite/lib/libgomp.exp: Add -B option for targets that
> > > 	use libgfortran.a%s in their specs.
> > >         * gcc/testsuite/lib/gfortran.exp: Likewise.
> > 
> > I tried this on powerpc64-linux for c,c++,fortran and got
> > failures for all of the tests in libgomp.c++ and libgomp.fortran
> > with "xgcc: lang_library_path: No such file or directory".
> > I'd say that it needs some more work, and that I should not have
> > approved the testsuite part earlier.
> > 
> > Janis
> 
> Janis,
>     This appears to be due to a stray space placed in the line...
> 
> +            lappend options "additional_flags=-B${blddir}/$ {lang_library_path}"
> 
> for the libgomp/testsuite/lib/libgomp.exp diff. If you make that line...
> 
> +            lappend options "additional_flags=-B${blddir}/${lang_library_path}"
> 
> the libgomp testsuite should pass fine.
>              Jack
> ps This typo was in the patch as originally posted.

Thanks, the libgomp tests work fine with that fix.  I committed the
patch as revision 143507.

Janis



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]