This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [lto][patch] Clear DECL_CONTEXT of PARM_DECL

From: Rafael Espindola <espindola at google dot com>
To: Diego Novillo <dnovillo at google dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Mon, 19 Jan 2009 22:45:06 +0000
Subject: Re: [lto][patch] Clear DECL_CONTEXT of PARM_DECL
References: <38a0d8450901191102i7be968d3x4db59f1269e660b8@mail.gmail.com> <b798aad50901191253ga734446y9ebe94f711f26aa0@mail.gmail.com>

> This isn't right.  If you set the context to NULL, the optimizers
> will think that PARM_DECLs are call-clobbered, but they aren't.
> The right thing here is to set them to the FUNCTION_DECL to which
> they belong.  If the function has been inlined the inliner will
> set it to the caller function.

If that was the case, we wouldn't have a problem. We are writing out a
reference to a function that has been inlined in all call sites
because it is reachable via a DECL_CONTEXT of a variable.

Do you have a testcase that fails with this patch? I don't think we
should keep information we don't need.

Cheers,
-- 
Rafael Avila de Espindola

Google | Gordon House | Barrow Street | Dublin 4 | Ireland
Registered in Dublin, Ireland | Registration Number: 368047

Follow-Ups:
- Re: [lto][patch] Clear DECL_CONTEXT of PARM_DECL
  - From: Diego Novillo

References:
- [lto][patch] Clear DECL_CONTEXT of PARM_DECL
  - From: Rafael Espindola
- Re: [lto][patch] Clear DECL_CONTEXT of PARM_DECL
  - From: Diego Novillo

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]