This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFA, fixincludes] add quotes around directory pathname
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Bruce Korb <bruce dot korb at gmail dot com>
- Cc: Sandra Loosemore <sandra at codesourcery dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 19 Jan 2009 10:45:17 -0800
- Subject: Re: [RFA, fixincludes] add quotes around directory pathname
- References: <49723F47.4070007@codesourcery.com> <49725357.6070703@gmail.com>
Bruce Korb wrote:
> Sandra Loosemore wrote:
>> Anyway, OK to check in now, or shall I wait for 4.5?
>
> It looks safe and sane to the fixinc maintainer. It should go
> into all active branches. The question is when. With the branch
> in a "stabilization" phase, it might be better to hold off until
> later, but I'll leave that up to the branch manager.
As far as I know, this isn't a regression; therefore, it should go in
4.5 only.
I'll take this moment to make a general appeal: please, let's try to
think of quoting/space issues in filenames. I've seen a bunch of bugs
where we assume that there are no spaces, no special characters, etc. in
various places. We should plan ahead for that.
Thanks,
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713