This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH,testsuite] fix gcc.target/arm/long-calls-*.c in Thumb-2 mode
- From: Janis Johnson <janis187 at us dot ibm dot com>
- To: Nathan Froyd <froydnj at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 14 Jan 2009 11:19:47 -0800
- Subject: Re: [PATCH,testsuite] fix gcc.target/arm/long-calls-*.c in Thumb-2 mode
- References: <20090114185040.GO28711@codesourcery.com>
- Reply-to: janis187 at us dot ibm dot com
On Wed, 2009-01-14 at 10:50 -0800, Nathan Froyd wrote:
> The patch below fixes several failures for tests on Thumb-2 targets.
>
> - GCC doesn't (currently) generate sibling calls in Thumb-2 mode;
>
> - The tests are looking for PLT markers, which don't get generated for
> Thumb-2, and may eventually not get generated for ARM mode.
>
> Neither of these things is core to the tests themselves: the tests are
> looking for the presence of short or long calls.
>
> Tested on arm-none-eabi. OK to commit?
>
> -Nathan
>
> 2009-01-14 Mark Mitchell <mark@codesourcery.com>
>
> * gcc.target/arm/long-calls-1.c: Tolerate the lack of sibling
> calls and/or PLT markers.
> * gcc.target/arm/long-calls-2.c: Tolerate the lack of sibling
> calls and/or PLT markers.
> * gcc.target/arm/long-calls-3.c: Tolerate the lack of sibling
> calls and/or PLT markers.
> * gcc.target/arm/long-calls-4.c: Tolerate the lack of sibling
> calls and/or PLT markers.
This looks OK to me but please ping an ARM maintainer for this patch.
Janis